[Sluggable] Use TranslationWalker for Translatable objects when looking for similar slugs

[ambroisemaupate]

Force translation walker to look for slug translations to avoid duplicated slugs.

---

Fixes #100, fixes #2530

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 76.47059% with 4 lines in your changes missing coverage. Please review.

Project coverage is 78.39%. Comparing base (0632ab1) to head (43809dc).
Report is 27 commits behind head on main.

Files	Patch %	Lines
src/Sluggable/Mapping/Driver/Annotation.php	60.00%	2 Missing ⚠️
src/Mapping/Annotation/Slug.php	50.00%	1 Missing ⚠️
src/Sluggable/Mapping/Driver/Xml.php	50.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2620      +/-   ##
==========================================
- Coverage   78.75%   78.39%   -0.36%     
==========================================
  Files         163      167       +4     
  Lines        8593     8613      +20     
==========================================
- Hits         6767     6752      -15     
- Misses       1826     1861      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ambroisemaupate]

Changelog and Unit test have been added.

[phansys]

Even if this may be considered as a fix, I guess the change will break the behavior for users relying on the current behavior.

Is this behavior documented? If not, I think this PR must also provide the required documentation.

How we can build a strong and indisputable argument to support this change as a fix and not as a new feature?

I'd like to hear more opinions here.
/cc @mbabker, @franmomu.

[tharsanvn]

Hello guys :)

Any news about this PR ?

[mbabker]

Even if this may be considered as a fix, I guess the change will break the behavior for users relying on the current behavior.

Is this behavior documented? If not, I think this PR must also provide the required documentation.

How we can build a strong and indisputable argument to support this change as a fix and not as a new feature?

I'd put it behind a config from the metadata instead of making a hard behavioral change. For the folks who want globally unique slugs, even across languages, they'd turn on this behavior with the config in the metadata.

If a platform is OK with duplicated slugs across languages, then it should also have something in place to deal with that potential duplication (i.e. if your route definition is /{locale}/{category}/{post}, then /en/tips/translation and /fr/tips/translation should already provide fully unique paths that allow querying the right info without requiring globally unique slugs for the category or post.).

[github-actions]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[ambroisemaupate]

How would you implement this as configurable? @mbakker
Adding uniqueOverTranslations option in Gedmo\Slug attribute ?

[ambroisemaupate]

@phansys @mbabker

I've added a new option uniqueOverTranslations (default: false) to trigger TranslationWalker::class ORM hint in getSimilarSlugs method.

[franmomu]

thanks @ambroisemaupate for keeping working on this! and @mbabker