Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 2616 #2617

Merged
merged 10 commits into from
Jun 9, 2024
Merged

Issue 2616 #2617

merged 10 commits into from
Jun 9, 2024

Conversation

oleg-andreyev
Copy link
Contributor

fixed #2616

@phansys phansys added Tree Bug A confirmed bug in Extensions that needs fixing. Needs Changelog note labels May 19, 2023
@phansys
Copy link
Collaborator

phansys commented Sep 7, 2023

Thank you @oleg-andreyev!

Could you please fix the failing tests and add a changelog note for the provided fix?

@oleg-andreyev
Copy link
Contributor Author

@phansys please approve workflow.

@phansys
Copy link
Collaborator

phansys commented Dec 22, 2023

@oleg-andreyev, could you please fix the CI pipeline and add a changelog note?

Thanks in advance.

Copy link

codecov bot commented Dec 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.39%. Comparing base (0632ab1) to head (abd7261).
Report is 28 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2617      +/-   ##
==========================================
- Coverage   78.75%   78.39%   -0.36%     
==========================================
  Files         163      167       +4     
  Lines        8593     8613      +20     
==========================================
- Hits         6767     6752      -15     
- Misses       1826     1861      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

CHANGELOG.md Outdated Show resolved Hide resolved
@oleg-andreyev
Copy link
Contributor Author

oleg-andreyev commented Mar 8, 2024

merged main branch, @phansys @franmomu

@franmomu franmomu merged commit 6730eb5 into doctrine-extensions:main Jun 9, 2024
17 of 18 checks passed
@franmomu
Copy link
Collaborator

franmomu commented Jun 9, 2024

thanks @oleg-andreyev!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A confirmed bug in Extensions that needs fixing. Tree
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ORM MaterializedPath must not call internal scheduleForDelete and call EM::remove
3 participants