Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New OpenGL-based Oscilloscope #322

Merged
merged 12 commits into from
Apr 28, 2024
Merged

New OpenGL-based Oscilloscope #322

merged 12 commits into from
Apr 28, 2024

Conversation

RichardTea
Copy link
Contributor

@RichardTea RichardTea commented Apr 10, 2024 •
edited
Loading

Builds on PR #321 , please merge that first

New OpenGL based oscilloscope to replace old one:

  • Much higher performance, can display hundreds of traces
  • CSV Import and Export
    • Trace configuration
    • Trace data
    • All packets or when the level changes (set before running)
  • Supports scrollback, limited only by available memory
  • Trigger improvements
    • New trigger type: Level cross. Triggers on the first packet where the level has crossed the trigger level.
    • Can trigger Receive views (Universe View) for summary analysis

Other changes that could not be easily separated as the new 'scope relies on them:

  • Use global tock throughout
  • Multi Universe View: Packet Timing Summary to show counts of packets that are too close, too far and 'slow refresh'.
  • BigDisplay performance improvement
  • Link new scope triggers to Universe View start/stop

richardetc and others added 7 commits April 10, 2024 10:44
@richardetc @RichardTea
Add optional NSIS signing header include
a725bc5 
Devs can insert their own installer signing logic and certificate(s)
@richardetc @RichardTea
Fix Windows firewall rules and uninstaller
30779a2
@RichardTea
New OpenGL based oscilloscope
afcf2d5 
Use global tock throughout
Add more timing detail to SACNSourceTableModel
BigDisplay performance improvement
Link new scope triggers to Universe View start/stop
@RichardTea
Cleanup listener sort functor
375dd24 
Use the typedef
@RichardTea
Update qmake project file
098e212
@RichardTea
Add sacnview natvis
0379308 
Defines CID and QHostAddress
@RichardTea
CMake unit tests for fps and glscopewidget
452eb6b
@RichardTea
Copy link
Contributor Author

I see a few more issues with Qt6 compatibility, will correct these momentarily

@RichardTea
Qt6 Compatibility
9a1dd48 
QTextStream::setCodec() is removed, use QTextStream::setEncoding()
QString::splitRef() is removed, use QStringView::split()
@RichardTea
gcc/clang do not like QOverload<void>()
d683dab
@RichardTea RichardTea mentioned this pull request Apr 10, 2024
Merged
@RichardTea
Avoid Undefined Behavior in sequence number check
0bfb548 
Signed integer overflow from a computation is UB
C++20 only defines overflowing constants
@docsteer docsteer merged commit 701b7a2 into docsteer:2.2-dev Apr 28, 2024
1 of 3 checks passed
@RichardTea RichardTea deleted the glscope branch May 3, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RichardTea @docsteer @richardetc