Convert project to CMake #305
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Legacy imports from ETC public code
WiP Many aspects unresolved
Correctly embed with CMake Qt6 updates Clazy updates Cleanup TS files
Explicitly include CheckCCompilerFlag for blake2.cmake Find Pcap using Wireshark cmake scripts Add Zlib as dependency
Update crash test for Qt6 Potentially added back macOS support (Untested)
Download and build as required
Download and build as required Update about dialog
n.b. Installers not yet ported to CMake
OpenSSL: Link shared, not static OpenSSL: Build debug as required OpenSSL: Don't copy documentation
Allows OpenSSL::SSL to pick up OpenSSL::Crypto in the same folder
RichardTea
reviewed
Jun 19, 2023
|
Very strongly recommend adding a toplevel CMakePresets.json to set up the default debug and release builds on each platform. Introduced in cmake 3.19, ignored by everything older than that. This makes cmake projects far nicer to use. |
Delay load pcap due to Npcap license restricting distribution. Check if pcap is found before use, and inform the user if not.
Fix icon Link missing Win32 libs
Correct OpenSSL shared lib extension Add NSIS installer Update Github actions artifacts Update readme Add missing download hashes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#273 Convert the project from QMake to CMake
Will also resolve the reason for #272 by using CPack
ToDo
Windows
Linux
macOS