Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes broken language guides link #21678

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixes broken language guides link #21678

wants to merge 1 commit into from

Conversation

koeliga
Copy link

@koeliga koeliga commented Dec 20, 2024

Description

Edited the link so that the languages are included in the parameters, since a standalone language guides page does not exist to my knowledge.

Related issues or tickets

Fixes #21677 , #21547

Reviews

  • Technical review
  • Editorial review
  • Product review

@koeliga koeliga requested a review from dvdksn as a code owner December 20, 2024 15:34
@github-actions github-actions bot added area/build Relates to Dockerfiles or docker build command dependencies Vendoring, packaging updates labels Dec 20, 2024
@netlify Netlify
Copy link

netlify bot commented Dec 20, 2024 •
edited
Loading

✅ Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit e1ed252
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/67658e97030a6b000829da95
😎 Deploy Preview https://deploy-preview-21678--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

dvdksn
dvdksn requested changes Dec 20, 2024
View reviewed changes
Copy link
Collaborator

@dvdksn dvdksn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is maintained in an upstream repository: moby/buildkit

It needs to be updated there in the source, or else it will be overwritten the next time we vendor that upstream. I'll have a look!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvdksn dvdksn dvdksn requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
area/build Relates to Dockerfiles or docker build command dependencies Vendoring, packaging updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[404]: /guides/language/
2 participants
@koeliga @dvdksn