[docker-container-exec_run] ExecDetachResult structure for exec_run in detached mode #3295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Piotr Nowak <[email protected]>
BillyGLW
force-pushed
the
fix/exec_run_detached_struct
branch
from
2546cbe
to
c90859b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested PoC - there is no way to trace exec_run's exit_codes once detach=True is specified as Id is lost within this library.
As Id will be retreived - user can use self.client.api.exec_inspect on its own - checking retrived exit_code when the command is done (or not).
I suggest not to combine ExecDetachResult into ExecResult namedtuple as status checking require additional request to docker daemon. Also, currently retreived
ExecResultwith exit_code as None is problematic as no other information is provided and there is no other way to check it.