Fail fast if unix socket is already in use by another process #1015
+93
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christopher Petito <[email protected]>
rumpl
reviewed
Dec 3, 2025
| // Check if socket file exists | ||
| if _, err := os.Stat(path); err == nil { | ||
| // Socket file exists - check if another process is using it | ||
| conn, err := net.DialTimeout("unix", path, 100*time.Millisecond) |
Member
There was a problem hiding this comment.
We should only check for the socket existence, not try and connect to it. This means we also need to make sure we cleanup the socket when cagent api exits
Contributor
Author
There was a problem hiding this comment.
fair, adjusting now
Contributor
Author
|
@rumpl feel free to undraft or close this once you know what you want to achieve here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure
cagent apifails fast if the desired unix socket is in use by another processCloses #1014