Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Debian Stretch as it's EOL #974

Merged
merged 1 commit into from
Jul 1, 2022

Conversation

BryanQuigley
Copy link
Contributor

It EOLs on June 30, 2022 per https://wiki.debian.org/LTS/Stretch.

@tianon
Copy link
Member

tianon commented Jun 27, 2022

Thanks for getting this started! ❤️

I think we need to do two things here:

  1. wait for something like https://lists.debian.org/debian-announce/2020/msg00003.html to make the EOL "official" 😇

  2. make sure we don't update the "default" for these two versions (for the same reason we still support stretch on them to begin with: Debian Buster is going to cause some reindexing headaches #582); I believe this means keeping debianSuites and setting both values to the empty string:

    versionDebianSuite="${debianSuites[$version]-$defaultDebianSuite}" # intentionally missing ":" so it can be empty (again, https://github.com/docker-library/postgres/issues/582 😭)

I'm happy to take over and look at making the changes for 2. there if you want. 👍

It EOLs on June 30, 2022 per https://wiki.debian.org/LTS/Stretch.

Keep bullseye from being the default on Postgres 10 or 11 (per docker-library#582).
@BryanQuigley
Copy link
Contributor Author

Thanks for the quick review!

  1. Not sure need to wait for the official announcement unless there is a chance it will be extended?
  2. I believe I made the necessary changes for this- it's set to nothing for postgres 10 and 11.

@tianon
Copy link
Member

tianon commented Jun 27, 2022

I'd like to keep it until the official announcement because we might get one more supported base image rebuild before it's officially EOL 😅

Copy link
Member

@tianon tianon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good -- I verified that generate-stackbrew-library.sh generates the appropriate thing (same as what exists right now, but minus the two stretch entries).

Now we just need the EOL to be official 👍

@tianon
Copy link
Member

tianon commented Jul 1, 2022

@tianon tianon merged commit eefb000 into docker-library:master Jul 1, 2022
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Jul 1, 2022
Changes:

- docker-library/postgres@eefb000: Merge pull request docker-library/postgres#974 from BryanQuigley/drop_stretch
BaurzhanSakhariev pushed a commit to crate/official-images that referenced this pull request Jul 18, 2022
Changes:

- docker-library/postgres@eefb000: Merge pull request docker-library/postgres#974 from BryanQuigley/drop_stretch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants