Set GOTOOLCHAIN to prevent go auto-upgrade
#491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Sep 22, 2023
Changes: - docker-library/golang@377e297: Merge pull request docker-library/golang#491 from infosiftr/gotoolchain - docker-library/golang@b643595: Set `GOTOOLCHAIN` to prevent go auto-upgrade
tianon
reviewed
Sep 29, 2023
| {{ if [ "1.20" ] | index(env.version | rtrimstr("-rc")) then "" else ( -}} | ||
| # don't auto-upgrade the gotoolchain | ||
| # https://github.com/docker-library/golang/issues/472 | ||
| ENV GOTOOLCHAIN=local |
There was a problem hiding this comment.
We might want to move this up a bit higher (later) to make sure our go invocations during install and verification don't somehow accidentally download. 👀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #472
Using an image that is too old for your project's minimum
goversion will causegoto fail and help inform the user that they are not using a new enoughgofor their project. So, rather than havinggoautomatically upgrading the toolchain (GOTOOLCHAIN=auto, the default), we have opted to move the image to encourage users to upgrade the image to get newer versions ofgo.(See also the comments on #472)