feat: tanstack-query 적용 #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YesHyeon
reviewed
Aug 5, 2023
src/constants/ROUTES.ts
Outdated
src/constants/QUERY_KEYS.ts
Outdated
There was a problem hiding this comment.
객체로 queryKey 관리하는 걸 권장한다고 하는데 좋은 것 같습니다!
YesHyeon
reviewed
Aug 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 연관된 이슈 번호
resolve #113
✨ 어떤 기능을 개발했나요?
이전에 쓰기로 했던 tanstack-query (구 react-query)를 적용했습니다
✅ 어떻게 해결했나요?
/constants/QUERY_KEYS.tsquery key들을 constant로 저장합니다/apiquery function - api 호출 함수들을 저장합니다/queries커스텀 훅을 제작하여 useQuery 혹은 useMutation을 리턴합니다📌 어떤 부분에 집중하여 리뷰해야 할까요?
api 호출하는 모든 부분을 바꿔 놓았는데 이해 안 가시는 부분 있으면 말씀해 주세요