Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: windows 환경에서도 pre-commit 스크립트를 실행하도록 수정 (#18) #18

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

Jaewon-pro
Copy link
Member

@Jaewon-pro Jaewon-pro commented Jul 23, 2024

🔗 이슈 연결

🚀 구현한 API

  • x

💡 반영할 내용 및 변경 사항 요약

  • chmod 대신 file.setExecutable()를 사용홥니다.
  • pre-commit.sh에서 gradle 실행을 OS에 따라 다르게 처리합니다.

🔍 리뷰 요청/참고 사항

  • 안되면 말씀해주세요!

@Jaewon-pro Jaewon-pro added the bug Something isn't working label Jul 23, 2024
@Jaewon-pro Jaewon-pro requested a review from hee9841 July 23, 2024 13:31
@Jaewon-pro Jaewon-pro self-assigned this Jul 23, 2024
Copy link
Collaborator

@hee9841 hee9841 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Jaewon-pro Jaewon-pro merged commit ef26f2b into main Jul 23, 2024
1 check passed
@Jaewon-pro Jaewon-pro deleted the feature/#4/supports-windows branch July 23, 2024 14:15
@Jaewon-pro Jaewon-pro changed the title Fix: windows 환경에서도 포메팅 스크립트가 실행하도록 수정 Fix: windows 환경에서도 pre-commit 스크립트를 실행하도록 수정 (#18) Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants