[pull] master from lightningnetwork:master #8
+178,341
−58,953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
git checkout master |
unit: remove GOACC, use Go 1.20 native coverage functionality
GitHub+docs: no longer accept typo fixes to fight PR spam
…another Before this commit, it was possible for a request to be sent on the `chanWatchRequests` channel in `WaitForChannelPolicyUpdate` and then for the `ticker.C` case to select _before_ the `eventChan` select gets triggered when the `topologyWatcher` closes the `eventChan` in its call to `handlePolicyUpdateWatchRequest`. This could lead to a "close of a closed channel" panic. To fix this, this commit ensures that we only move on to the next iteration of the select statement in `WaitForChannelPolicyUpdate` once the request sent on `chanWatchRequests` has been fully handled.
For any embedded struct, the `yaml:",inline"` tag is required.
build: add yaml tags to some LogConfig fields
We now use dedicated methods to properly document the flakes in *one* place.
We now make sure the proxy server is running on a unique port. In addition, we close the old conn before making a new conn.
This commit adds a test to demonstrate that if we receive two identical updates (which can happen if we get the same update from two peers in quick succession), then our rate limiting logic will be hit early as both updates might be counted towards the rate limit. This will be fixed in an upcoming commit.
In `handleChanUpdate`, make sure to grab the `channelMtx` lock before making any DB calls so that the logic remains consistent.
Remove an old TODO, which has been fixed with the `NoWait` flag for coop close.
Hence finish an old TODO.
As they are fixed now.
lntest: wait for ChanUpdate req to be fully processed before sending another
The ValidateConfig method needs to account for the caller already having an initialised build.SubLoggerManager and then should not override it.
config: only create a sub-log manager if one doesnt already exist
Nudging test authors towards not mining too many blocks makes sense, especially in lnd where we have a lot of integration tests. But the lntest package is also used in other projects where this restriction might lead to large refactors. To be able to stage those refactors we also want to allow this limit to be configurable if lntest is used as a library.
lntest: make mining block limit configurable
…teLimit discovery: obtain channelMtx before doing any DB calls in `handleChannelUpdate`
This commit adds an integration test that verifies the funding timeout behavior in the funding manager, in dev/integration test. Signed-off-by: Nishant Bansal <nishant.bansal.282003@gmail.com>
This is added to fix a flake found in starting the node.
We now start the sweeping process if there are normal inputs to partially cover the budget.
lnd: make sure startup flow is not aborted
cmd: fix incorrect error code
In this commit, we reduce log spam a bit during state transitions. We only log the type of the event when sending the event, as we'll print the same event when creating the queue "applying", and later when processing". Next we remove the "applying" log as that first event will always be logged twice. The combo of these to changes makes the logs much easier to follow.
…arly_offer In this commit, we fix a flake in the `TestRbfChannelFlushingTransitions/early_offer` test. The fix is simple: this is actually an "iteration", as we have a self transition to the ChannelNegotiation state first. We also don't need to send the remoteOffer, so we set `sendInit` to false. The offer still needs to be passed in to ensure that the assertions work however.
Sweep inputs even the budget cannot be covered
lnwallet/chancloser: fix flake in TestRbfChannelFlushingTransitions/early_offer
This commit adds the custom channel data for closed channels which represents the initial funding state as well as the final balances at closing time.
The pending force close and pending waiting close channels didn't have their custom channel data populated yet.
lnrpc+rpcserver: add custom channel data for closed channels
refactor: use maps.Copy for cleaner map handling
Previously, if a DB version wasn't available, we re-ran all schema migrations without verifying the schema version. However, setting a base schema version is essential because some earlier migrations were not idempotent. This commit addresses the issue by using the current schema version provided by sqlc as the base.
sqldb: establish a base DB version even if it's not yet tracked
We want to encourage new contributors to review code instead of creating their own PRs as a first contribution.
mod: use sqldb v1.0.8
README+docs: add code review checklist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )