Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove note about multi-quantile being python-only #9854

Merged
merged 2 commits into from
Dec 6, 2023
Merged

Remove note about multi-quantile being python-only #9854

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bec98ce
remove note about multi-quantile being python-only
david-cortes Dec 6, 2023
0f046d1
update note about supported interfaces
david-cortes Dec 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions demo/guide-python/quantile_regression.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,7 @@

.. note::

The feature is only supported using the Python package. In addition, quantile
crossing can happen due to limitation in the algorithm.
Quantile crossing can happen due to limitation in the algorithm.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python and R. We still have a couple of other interfaces there.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question there: apart from the java interface, aren't the other interfaces maintained independently in repositories from other people/organizations? Are these docs meant to refer to only the interfaces from this repository, or to all the other interfaces linked from the docs too?

Also, should it mention it being supported in the C package, or is that assumed to be a given?

Copy link
Member

@trivialfis trivialfis Dec 6, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question there: apart from the Java interface, aren't the other interfaces maintained independently

Yes, but the JVM package has multiple interfaces, like Scala Spark, Flink, etc. We want to remove the CLI, but need a few releases.

Also, should it mention it being supported in the C package, or is that assumed to be a given?

Feel free, we don't have any requirement on the C interface. It's mostly used for inference anyway.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood. Updated the note then to mention the R and C packages.


"""
import argparse
Expand Down
Loading