Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc] Fix edge_ids()'s error messages #7434

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

songqing
Copy link
Contributor

Description

When calling edge_ids(), if there are more than one invalid edges, the error message can't print any invalid (src, dst) value, but only print "ValueError: only one element tensors can be converted to Python scalars", fix it.

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

Changes

@dgl-bot
Copy link
Collaborator

dgl-bot commented May 29, 2024

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented May 29, 2024

Commit ID: dbcc7ee

Build ID: 1

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@songqing
Copy link
Contributor Author

@Rhett-Ying could you help review this small PR? if no error message, we can't easily found the error edges

F.as_scalar(F.gather_row(u, idx)),
F.as_scalar(F.gather_row(v, idx)),
len(idx),
F.as_scalar(F.gather_row(u, idx[0])),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's ok to print all the invalid node pairs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can't now, there will be an error "ValueError: only one element tensors can be converted to Python scalars" when calling as_scalar(), and will not print any data, so I change it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants