Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package Settings Integration + ServiceName Validation #32

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

labcubedev
Copy link

  • Added Package Settings
  • Extended ServiceName validation

* Extended ServiceName validation
@dmitry-pavlov
Copy link
Owner

@labcubedev could you please clarify why did this change? I mean how does it improves the code? TIA!

@labcubedev
Copy link
Author

@dmitry-pavlov Sorry, I was unavailable the past two weeks.

I have added two package settings to the project: ServiceName and ServiceUri
These store the last used name and URI of the service that the user entered within the ServiceEndpointWizardPage.

Additionally, the ServiceName input will now be validated as a namespace so that the code generator doesn't generate an invalid namespace.

@dmitry-pavlov
Copy link
Owner

Additional question @labcubedev : do I get it right that these package settings remembering the last values entered by the user? Will it be per client, or per extension? I mean what if we have 2 (or more) API clients in the same project: so the user provides name API1 for the first and then API2 for the second. What will (s)he will see on ServiceEndpointWizardPage?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants