fix: implement libvirt TLS server verification #1184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add proper TLS handshake verification for libvirt connections over TLS. When connecting to libvirt over TLS, the server writes a verification byte after the TLS handshake to indicate whether the client certificate and/or IP address verification succeeded. This was not being handled, which could lead to connection issues in some environments. This change: - Reads the server verification byte after TLS connection - Properly handles verification failures with clear error messages - Improves robustness of TLS connections to libvirt - Follows the libvirt TLS protocol as documented in go-libvirt issues Also improves user detection fallback when /etc/passwd lookup fails by using os.Getuid() directly for container environments. References: - digitalocean/go-libvirt#89 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add proper TLS handshake verification for libvirt connections over TLS.
When connecting to libvirt over TLS, the server writes a verification byte after the TLS handshake to indicate whether the client certificate and/or IP address verification succeeded. This was not being handled, which could lead to connection issues in some environments.
This change:
Also improves user detection fallback when /etc/passwd lookup fails by using os.Getuid() directly for container environments.
References: digitalocean/go-libvirt#89 (comment)