fixed a bug in brush.js #23
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the brush.js code:
I replaced the following line of code
var N_PREVIOUS_SPEEDS = 15; //how many previous speeds we store
with:
const N_PREVIOUS_SPEEDS = 15; //how many previous speeds we store
Reason:
In this case, N_PREVIOUS_SPEEDS is intended to represent the number of previous speeds stored, and its value is not expected to change. By using const, you provide clarity to anyone reading the code that this variable is meant to be constant throughout the program.