Correct channel detection in MagickImage.blur #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlemstra
reviewed
Feb 5, 2024
src/magick-image.ts
Outdated
| else if (radiusOrChannel !== undefined) | ||
| channels = radiusOrChannel; | ||
| if (radiusOrChannels !== undefined) { | ||
| if (sigmaOrUndefined === undefined) { |
There was a problem hiding this comment.
Can you remove the { here and in the else to have this in the same style as the rest of the project? The first one should stay because it is multiline.
|
Fair point! I've added a test and updated that if statement for you. |
dlemstra
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Channelsenum is converted to numerical values on compilation, meaning e.g.MagickImage.blur(Channels.Blue)will currently be interpreted asMagickImage.blur(4, 1).I found this problem during the implementation of
MagickImage.gaussianBlur(radius: number, channels: Channels). Unlike there, we don't need to omit it here as we can identify the usage ofMagickImage.blurby the presence of other arguments. Namely, if asigmavalue is given then the first argument is a radius, otherwise it is aChannelsvalue.