Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add connectedComponents to MagickImage #114
Add connectedComponents to MagickImage #114
Changes from 7 commits
c3cf4e9
8a21118
553bdcf
2e1c77e
4e1e8b6
4bb0971
8743a16
70f1aa5
90ece23
f30d1c4
8343af0
b2665f6
ff87028
a98b75c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if I want to keep this here because that would also require me to maintain it. A description of the method and parameters and the
@see
should be sufficient?And should we not add this documentation to the interface instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that's totally fair. Maintenance concerns are always a good reason to be wary of too much "extra" stuff.
I think
@example
theoretically shouldn't be much of a maintenance concern though, at least in this case:IMagickImage
api likely won't change drasticallyI feel like it's a good first-touch bit of context for users on how to use this in a js-specific setting. Descriptions tell you what it does,
@see
gives extra information like the various defines available, but@example
shows how to use it in js specifically.Just sharing my thoughts though! If it still feels like something you'd prefer to not have to think about, will gladly remove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will remove them myself after merging the PR. I think we should put the examples somewhere else.