Fix Bugzilla Issue 24637 -- [REG 2.104] Cannot insert const/immutable elements into DList #9042

RubyTheRoobster · 2024-08-03T17:12:14Z

No description provided.

… elements into DList

dlang-bot · 2024-08-03T17:12:18Z

Thanks for your pull request and interest in making D better, @RubyTheRoobster! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
I have provided a detailed rationale explaining my changes
New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close	Bugzilla	Severity	Description
✓	14138	major	std.parallelism.task breaks @safety
✓	15315	normal	can break immutable with std.algorithm.move
✓	20870	normal	std.outbuffer.printf is trusted
✓	20872	normal	std.array.assocArray trusts user-provided 'front' for values
✓	22293	enhancement	Nullable should define opCast!bool
✗	23300	normal	std.array : array wrongly propagates scopeness of source
✓	24637	regression	[REG 2.104] Cannot insert const/immutable elements into DList
✓	24667	normal	goo.gl is going away
✓	24685	major	std.stdio.File.rawRead allows reading raw pointers from files in @safe code

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + phobos#9042"

std/container/dlist.d

RubyTheRoobster · 2024-08-09T17:48:30Z

BuildKite is failing with:

CMake Error at cmake/Modules/FindLLVM.cmake:62 (message):
  Unsupported LLVM version 14.0.0 found (/bin/llvm-config).  At least version
  15.0 is required.  You can also set variables 'LLVM_ROOT_DIR' or
  'LLVM_CONFIG' to use a different LLVM installation.
Call Stack (most recent call first):
  cmake/Modules/FindLLVM.cmake:190 (_LLVM_FAIL)
  CMakeLists.txt:37 (find_package)

This seems to be a bug.

kinke · 2024-08-09T19:23:14Z

AFAIK, this depends on @ibuclaw re-creating his Buildkite agents using the latest docker image definition: dlang/ci#489 (comment)

RazvanN7 · 2024-08-19T12:06:27Z

@RubyTheRoobster maybe a rebase will fix the failing buildkite test.

…g#9019) * Move `std.math.exponential.pow` implementation outside template * Fix compilation on Mac

Caught with grep -Er '\(\$[A-Za-z]'

for link in $(grep -Eor 'https?://[^\\)", ]+' | grep -v dlang.org \ | grep -Eo 'https?://.+'); do (printf "%s: " "$link"; curl -Is "$link" \ | head -n1) | grep -E '4..$'; done for link in $(grep -Eor '\\$\\(HTTP .+, ' | grep -v dlang.org \ | cut -d' ' -f2- | sed 's/, .*$//'); do out="$(curl -Is "$link")"; \ (! [ $? = 0 ] || printf '%s' "$out" | head -n1 | grep -Eq '4..') \ && printf '%s\\n' "$link"; done

It's implemented in Windows but it's not part of standard C. https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference/fdopen

Co-authored-by: Dennis Korpel <[email protected]>

Note: www.canonware.com/download/jemalloc/jemalloc-latest/doc/jemalloc.html jemalloc link isn't responding, and it now lives at jemalloc.net (see also https://github.com/jemalloc/jemalloc?tab=readme-ov-file#readme). Fixes Bugzilla Issue 24667 - goo.gl is going away.

@safe

…rs from files in @safe code (dlang#9030)

…ng#9032)

dlang#9036)

The second opCast overload is necessary to allow built-in implicit conversions (e.g., mutable to const) to be performed explicitly via a cast expression. Nullable.opEquals depends on this behavior.

RubyTheRoobster · 2024-08-21T02:53:38Z

I have never had to perform a rebase before, so I have no idea if all of the extra commits are acceptable or not.

CyberShadow · 2024-08-21T05:52:41Z

Unfortunately no, they are an indication that something went wrong with the rebase.

LightBender · 2024-10-27T07:56:22Z

This is being closed because of the incorrect rebase. Please reopen with just the initial commits. @thewilsonator if you're feeling like a project...

RubyTheRoobster added 2 commits August 3, 2024 13:02

Fix Bugzilla Issue 24637 -- [REG 2.104] Cannot insert const/immutable…

55a9559

… elements into DList

Remove some trailing whitespace.

c964787

RubyTheRoobster requested a review from PetarKirov as a code owner August 3, 2024 17:12

dlang-bot added the Bug Fix label Aug 3, 2024

Fix Style Violations

2ff13d5

thewilsonator reviewed Aug 4, 2024

View reviewed changes

std/container/dlist.d Outdated Show resolved Hide resolved

Fix whitespace (again)

ea8650a

RubyTheRoobster requested a review from thewilsonator August 5, 2024 20:42

thewilsonator approved these changes Aug 6, 2024

View reviewed changes

std/container/dlist.d Outdated Show resolved Hide resolved

Add Newline

b5afd4d

kinke reviewed Aug 6, 2024

View reviewed changes

std/container/dlist.d Outdated Show resolved Hide resolved

RubyTheRoobster added 3 commits August 6, 2024 20:35

Remove unecessary variable

cba26e4

Make test case stronger and remove useless contructor overload

8ec19b0

Fix whitepsace

20e722c

RubyTheRoobster requested a review from kinke August 9, 2024 15:23

0-v-0 and others added 11 commits August 20, 2024 22:51

Remove std.conv import from quickSortImpl

6eedf00

Move std.math.exponential.pow implementation outside template (dlan…

3c360d5

…g#9019) * Move `std.math.exponential.pow` implementation outside template * Fix compilation on Mac

fix ddoc blunders

4199740

Caught with grep -Er '\(\$[A-Za-z]'

fix minor spelling mistake

1ec49dd

std.stdio: fdopen is a POSIX library function

c740a4c

It's implemented in Windows but it's not part of standard C. https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference/fdopen

std.json: Document opEquals (dlang#8975)

fb1d5da

Co-authored-by: Dennis Korpel <[email protected]>

Fix Lockstep attribute limitation

811e8eb

Address style errors

946735f

Fix problems with reverse

e261862

Quirin Schroll and others added 11 commits August 20, 2024 22:51

Address style errors

4fd0bd2

DEPRECATED_2.107 code removed (dlang#9028)

b7d5fc0

Adds check bounds of year to std.datetime.date.Date

c2e160f

Bugzilla 23300 - add testcase for std.array on scope InputRange

51a60bb

Fix Bugzilla 24685 - std.stdio.File.rawRead allows reading raw pointe…

b0ee848

…rs from files in @safe code (dlang#9030)

Fix Bugzilla 14138 - std.parallelism.task breaks @safety (dlang#9033)

c3a867c

Fix Bugzilla 15315 - can break immutable with std.algorithm.move (dla…

250553b

…ng#9032)

Fix Bugzilla 20870 - std.outbuffer.printf is trusted (dlang#9037)

4badf4b

Fix Bugzilla 20872 - std.array.assocArray trusts user-provided 'front… (

3cc69b0

dlang#9036)

Silence buildkite style failure on std.range

8b2a6e2

Fix Bugzilla 22293: opCast!bool for Nullable (dlang#9039)

a7885a1

The second opCast overload is necessary to allow built-in implicit conversions (e.g., mutable to const) to be performed explicitly via a cast expression. Nullable.opEquals depends on this behavior.

RubyTheRoobster requested review from jmdavis, MetaLang, CyberShadow, schveiguy, andralex, JackStouffer, wilzbach, ibuclaw and dnadlinger as code owners August 21, 2024 02:52

dlang-bot added the Enhancement label Aug 21, 2024

LightBender closed this Oct 27, 2024

thewilsonator mentioned this pull request Oct 27, 2024

Fix bugzilla issue 24637 #9071

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix Bugzilla Issue 24637 -- [REG 2.104] Cannot insert const/immutable elements into DList #9042

Fix Bugzilla Issue 24637 -- [REG 2.104] Cannot insert const/immutable elements into DList #9042

RubyTheRoobster commented Aug 3, 2024

dlang-bot commented Aug 3, 2024 •

edited

Loading

RubyTheRoobster commented Aug 9, 2024

kinke commented Aug 9, 2024

RazvanN7 commented Aug 19, 2024

RubyTheRoobster commented Aug 21, 2024

CyberShadow commented Aug 21, 2024

LightBender commented Oct 27, 2024

Fix Bugzilla Issue 24637 -- [REG 2.104] Cannot insert const/immutable elements into DList #9042

Fix Bugzilla Issue 24637 -- [REG 2.104] Cannot insert const/immutable elements into DList #9042

Conversation

RubyTheRoobster commented Aug 3, 2024

dlang-bot commented Aug 3, 2024 • edited Loading

Bugzilla references

Testing this PR locally

RubyTheRoobster commented Aug 9, 2024

kinke commented Aug 9, 2024

RazvanN7 commented Aug 19, 2024

RubyTheRoobster commented Aug 21, 2024

CyberShadow commented Aug 21, 2024

LightBender commented Oct 27, 2024

dlang-bot commented Aug 3, 2024 •

edited

Loading