Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly mark lines constructor #9035

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Properly mark lines constructor #9035

wants to merge 1 commit into from

Conversation

schveiguy
Copy link
Member

Still need

  • bug report
  • test

I just first want to see that it doesn't break anything.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @schveiguy!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#9035"

@schveiguy
Copy link
Member Author

Replaces #9034

thewilsonator
thewilsonator approved these changes Jul 29, 2024
View reviewed changes
std/stdio.d Outdated Show resolved Hide resolved
@schveiguy
Copy link
Member Author

I'm completely confused on the style problem. What style thing is wrong?

@thewilsonator
Copy link
Contributor

That is unrelated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thewilsonator thewilsonator thewilsonator approved these changes

@CyberShadow CyberShadow Awaiting requested review from CyberShadow CyberShadow will be requested when the pull request is marked ready for review CyberShadow is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schveiguy @dlang-bot @thewilsonator