-
-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge Makefiles #8862
Merge Makefiles #8862
Conversation
Thanks for your pull request and interest in making D better, @kinke! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + phobos#8862" |
dcad4cb
to
c36d113
Compare
Wrt. zlib (the only C parts of Phobos), the situation was a bit wild:
With the generic |
Dependant PR merged. |
Thanks! - Landing this probably breaks Windows CI for DMD master, requiring dlang/dmd#15920 to land in tandem. |
Depends on
dlang/dmd#15894 +dlang/dmd#15920 (pushed as same-named DMD branchmakefiles
for CI), then seems to work already with these pretty minimalposix.mak
adaptations (see first commit - review commit-by-commit). :)For CI, this makes use of the special feature that branch CI pipelines (for branches pushed to the dlang repo) try to clone a same-named branch on the other dlang repo. So the relevant pipelines to look at are the branch pipelines, not the PR pipelines. For GitHub Actions, the branch pipeline jobs are displayed as
(push)
(vs.(pull_request)
) here in the GUI;for Azure CI, it needs to be looked up manually.