Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update conv.d: textImpl(): make static if more readable. #8854

Merged
merged 2 commits into from
Nov 25, 2023

Conversation

BoQsc
Copy link
Contributor

@BoQsc BoQsc commented Nov 25, 2023

Adds newlines at the end of statements in the source code.

Adds newlines at the end of statements in the source code.
@BoQsc BoQsc requested a review from JackStouffer as a code owner November 25, 2023 13:45
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @BoQsc! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#8854"

…le Check

By mistake I've added trailing spaces in the source code that were unnecessary.
@BoQsc
Copy link
Contributor Author

BoQsc commented Nov 25, 2023

Random unrelated errors on some MacOS will probably prevent auto-merge into D Library.
image

Triggering the test again would let this pull request to pass?

@thewilsonator
Copy link
Contributor

Random unrelated errors on some MacOS

Yeah that happens some times.

@thewilsonator thewilsonator merged commit 39712a1 into dlang:master Nov 25, 2023
10 of 11 checks passed
@BoQsc BoQsc deleted the patch-1 branch November 25, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants