Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 11111 - std.algorithm.canFind should support Needles... #8845

Merged
merged 2 commits into from
Nov 20, 2023

Conversation

ntrel
Copy link
Contributor

@ntrel ntrel commented Nov 6, 2023

The requirement that each needle must be a range is arbitrary, so remove it.
Note: This overload of canFind calls find(haystack, needles) which calls startsWith, which accepts mixed element and range needles.
Also rename the type of the find overload's needles parameter to reflect this.

@dlang-bot
Copy link
Contributor

dlang-bot commented Nov 6, 2023

Thanks for your pull request and interest in making D better, @ntrel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
11111 enhancement std.algorithm.canFind should support Needles...

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#8845"

@ntrel
Copy link
Contributor Author

ntrel commented Nov 19, 2023

Ping

@thewilsonator
Copy link
Contributor

merge conflict

The requirement that each needle must be a range is arbitrary, so remove
it.
Note: This overload of `canFind` calls `find(haystack, needles)` which
calls `startsWith`, which accepts mixed element and range needles.
@dkorpel dkorpel merged commit 7417040 into dlang:master Nov 20, 2023
11 checks passed
@ntrel ntrel deleted the canFind-needles branch November 24, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants