Use moved core.lifetime.move{,Emplace} for std.algorithm.mutation.move{,Emplace} #6848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @wilzbach! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + phobos#6848" |
wilzbach
requested review from
andralex,
JackStouffer and
PetarKirov
as code owners
This was referenced Jan 31, 2019
edi33416
approved these changes
Feb 20, 2019
edi33416
reviewed
Feb 20, 2019
| assertThrown!Error(move(p)); | ||
| assertThrown!Error(move(p, pp)); | ||
| assertThrown!Error(swap(p, pp)); | ||
| //import std.exception : assertThrown; |
There was a problem hiding this comment.
Why not delete instead of commenting?
There was a problem hiding this comment.
I wanted to see whether this is the only issue.
As explained, the core.lifetime functions are technically different and using them is a breaking change.
LightBender
added
the
Review:Salvage
|
@thewilsonator this one is for you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In dlang/druntime#2442,
doesPointTowasn't ported as it's quite big (dlang/druntime#2447).That's why one test which test this behavior would fail now. Should we simply move
doesPointToto druntime as proposed, s.t. we don't need to maintain two implementations?