Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

moveEmplace: optimise and make it betterC friendly #2565

Closed
wants to merge 1 commit into from

Conversation

9il
Copy link
Member

@9il 9il commented Apr 17, 2019

No description provided.

@9il 9il requested review from andralex and wilzbach as code owners April 17, 2019 09:03
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @9il!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + druntime#2565"

@thewilsonator
Copy link
Contributor

Please also update the Phobos copy as wells they don't get out of sync.

@9il
Copy link
Member Author

9il commented Apr 17, 2019

btw, why Phobos just does not import core.lifetime?

@9il
Copy link
Member Author

9il commented Apr 17, 2019

dlang/phobos#6964

@thewilsonator
Copy link
Contributor

Phobos has a check for no internal pointers or something that can't be in druntime because it depends on too much of phobos.

@9il
Copy link
Member Author

9il commented Apr 17, 2019

Is it because of optimization reasons?

@thewilsonator
Copy link
Contributor

No, its because druntime cannot depend on phobos.

@9il
Copy link
Member Author

9il commented Apr 17, 2019

Yes, but phobos can depend on druntime. Why not to use public imports?

@jacob-carlborg
Copy link
Contributor

Yes, but phobos can depend on druntime. Why not to use public imports?

Because the implementation is not the same.

@wilzbach
Copy link
Member

Druntime would need this to match the Phobos implementation: #2447

@9il 9il closed this Apr 17, 2019
@9il
Copy link
Member Author

9il commented Apr 17, 2019

I closed it because of the same change in Phobos fails.

@9il 9il reopened this Apr 17, 2019
@9il 9il closed this Apr 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants