-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.github/workflows/ci.yml: add gdc build job #775
Open
the-horo
wants to merge
1
commit into
dlang-community:master
Choose a base branch
from
the-horo:ci-add-gdc-job
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrei Horodniceanu <[email protected]>
DCD BUILD FAILED Build statistics: statistics (-before, +after)
client size=1052480 bin/dcd-client
server size=3102008 bin/dcd-server
-rough build time=59s
+rough build time=61s
-DCD run_tests.sh Elapsed (wall clock) time (h:mm:ss or m:ss): 0:07.97
-DCD run_tests.sh Maximum resident set size (kbytes): 36204
+DCD run_tests.sh Elapsed (wall clock) time (h:mm:ss or m:ss): 0:08.01
+DCD run_tests.sh Maximum resident set size (kbytes): 36160
short requests: (240x)
- min request time = 0.011ms
- 10th percentile = 0.148ms
- median time = 0.383ms
- 90th percentile = 0.642ms
- max request time = 1.569ms
+ min request time = 0.009ms
+ 10th percentile = 0.165ms
+ median time = 0.387ms
+ 90th percentile = 0.704ms
+ max request time = 1.593ms
long requests over 10ms: (51x)
- min request time = 12.435ms
- 10th percentile = 13.236ms
- median time = 14.852ms
- 90th percentile = 16.650ms
- max request time = 21.541ms
+ min request time = 12.775ms
+ 10th percentile = 13.950ms
+ median time = 15.498ms
+ 90th percentile = 17.499ms
+ max request time = 23.094ms
top 5 GC sources in server: Full build output
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in #774 (comment) this PR adds a CI job that builds and tests DCD with gdc.
Implementing this has shown some problems:
DCD/common/dub.sdl
Line 3 in 27b1042
-run
which is unsupported by gdc. One can solve this by using gdmd though/usr/bin/gdmd-12
to/usr/bin/gdmd
which will use gdc-12.-vcolumns
which gdmd doesn't understand. This has been fixed in D-Programming-GDC/gdmd@0a64b92 but it will take some time before it makes its way into downstream packages.These issues can be sidestepped if the makefile is used to build the package instead of dub. This only complicates things a little in the case of testing multiple libdparse versions which was a requirement of #774 (comment).
I've chosen to write a separate job instead of adding to the old one as most of the steps are different and adding
if compiler == gdc
andif compiler != gdc
everywhere didn't seem good. The uselessDC
exports have been removed assetup-dlang
already sets the environment variable.