Refactor duplicate counting functions and tests #3
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors duplicate counting functions and tests by introducing a new O(n) set-based counting function and creating a generic test framework to reduce code duplication.
- Added a new
countDuplicatesSetfunction using unordered sets for O(n) performance - Replaced individual test functions with a generic
runTeststemplate function - Added utility functions for vector string conversion and improved test output formatting
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| for (size_t i = 0; i < expected.size(); ++i) { | ||
| std::cout << expected[i] << (i+1<expected.size()? ",":""); | ||
| // normalize for comparison if vector | ||
| if constexpr (std::is_same_v<decltype(got), std::vector<int>>) { |
There was a problem hiding this comment.
The hardcoded std::vector<int> type check makes this template less generic. Consider using a type trait or concept to check if the type is a container that supports sorting, making the template more reusable for other vector types.
| countDuplicatesSet, | ||
| [](auto& tc){ return tc.expectedCount; }, | ||
| [](auto v){ return std::to_string(v); } | ||
| ); |
There was a problem hiding this comment.
[nitpick] Missing blank line after the closing parenthesis for consistency with the formatting pattern used in other runTests calls (compare with lines 169, 185).
| ); | |
| ); |
Co-authored-by: Copilot <[email protected]>
1 participant
No description provided.