Add next meeting date field to Meeting Model #2197
Open
+36
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
| @@ -95,6 +95,7 @@ class Meeting(models.Model): | |||
| ) | |||
| treasurer_report = models.TextField(blank=True) | |||
| treasurer_report_html = models.TextField(editable=False) | |||
| next_meeting_date = models.DateField(null=True, blank=True) | |||
There was a problem hiding this comment.
Suggested change
| next_meeting_date = models.DateField(null=True, blank=True) | |
| next_meeting_date = models.DateField( | |
| null=True, | |
| blank=True, | |
| help_text=_("This will be shown on the website as the board's next meeting date. The latest meeting's Next Meeting Date will be used.") | |
| ) |
I wonder if a little bit of context will be helpful to future DSF Secretaries.
| occasionally rescheduled for attendance. | ||
| {% endblocktranslate %} | ||
| {% if next_meeting_date %} | ||
| {% translate "Next meeting scheduled for: " context "Following meetings schedule" %} |
There was a problem hiding this comment.
Suggested change
| {% translate "Next meeting scheduled for: " context "Following meetings schedule" %} | |
| {% translate "The next meeting is scheduled for: " context "Following meetings schedule" %} |
I think if this were a bullet point, I would agree with your more concise version, but since it's part of a paragraph, I think a complete sentence reads a bit better.
| @@ -104,6 +106,7 @@ def test_latest_meeting_minutes(self): | |||
| self.assertContains(response, "Latest DSF meeting minutes") | |||
|
|
|||
| self.assertContains(response, "DSF Board monthly meeting, May 12, 2023") | |||
| self.assertContains(response, "Next meeting scheduled for: June 13, 2023") | |||
There was a problem hiding this comment.
We may want to include a test for when there is no next_meeting_date in the context to confirm "Next meeting schedule for" doesn't appear.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds next meeting field discussed in #1705
Updates the foundation sidebar to include the next meeting date to add transparency to the community. At the direction of thibaudcolas discussed in the issue.
Example with the last meeting having a
next_meeting_dateUnsure if it would be better to have the next_meeting_date be calculated inside the template.