Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use code when rejecting connection #487

Closed
wants to merge 1 commit into from
Closed

Use code when rejecting connection #487

wants to merge 1 commit into from

Conversation

daveisfera
Copy link

Fixed #486

@carltongibson
Copy link
Member

Can we add a regression test for this change?

@daveisfera
Copy link
Author

I'm not familiar with the tests. Can you point me to where that would be added?

@Kludex
Copy link

Kludex commented Dec 19, 2023

This PR is wrong. Daphne doesn't support WebSocket Denial Response. The status code 403 is correct.

The message["code"] is not a HTTP status code.

@daveisfera
Copy link
Author

This PR is wrong. Daphne doesn't support WebSocket Denial Response. The status code 403 is correct.

The message["code"] is not a HTTP status code.

I'm not sure what that's supposed to mean. I've tested this change and it works

@carltongibson
Copy link
Member

Closing as per ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement WebSocket Denial Response extension
3 participants
@daveisfera @carltongibson @Kludex