Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change packaging to use setuptools declarative config in setup.cfg #296

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

michael-k
Copy link
Contributor

For the same change in Django, see PR django/django#12013 and issue 30948.

I'm not a packaging expert. According to my tests, the following blocks should lead to the same result:

# setup.py
setup(
    packages=find_packages() + ["twisted.plugins"],
)
# setup.cfg
[options]
packages = find_namespace:

[options.packages.find]
exclude =
    tests

I tried to convert setup.py 1:1 to setup.cfg with two exceptions:

  1. python_requires = >=3.5 is new (Django also has a python_requires)
  2. Classifier Programming Language :: Python :: 3 :: Only is new and also present in Django.

@carltongibson carltongibson self-requested a review February 5, 2020 20:06
Base automatically changed from master to main March 3, 2021 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant