Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: fail on use ChannelsLiveServerTestCase when daphne is not installed #1943

Closed
wants to merge 2 commits into from
Closed

feat: fail on use ChannelsLiveServerTestCase when daphne is not installed #1943

wants to merge 2 commits into from

Conversation

bertonha
Copy link

#1942 suggestion for fix the issue

@carltongibson carltongibson linked an issue Oct 28, 2022 that may be closed by this pull request
Daphne still needed to use channels.testing #1942
Open
carltongibson
carltongibson reviewed Oct 28, 2022
View reviewed changes
Copy link
Member

@carltongibson carltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have a regression test here... 🤔

Perhaps an environment running the tests without Daphne installed (to make sure that works).

@bertonha
Copy link
Author

I think we have 2 options here:

  • dont install daphne at all on the tests
  • duplicate tests to run with daphne and without.

on the tests the class ChannelsLiveServerTestCase is not tested so far so daphne is not really needed at moment

@bertonha bertonha closed this by deleting the head repository Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carltongibson carltongibson carltongibson left review comments

Assignees
No one assigned
Labels
None yet
Projects
Channels v4.1 updates
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Daphne still needed to use channels.testing
2 participants
@bertonha @carltongibson