fix pagination issue #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #99 +/- ##
=======================================
Coverage ? 92.87%
=======================================
Files ? 4
Lines ? 351
Branches ? 0
=======================================
Hits ? 326
Misses ? 25
Partials ? 0 ☔ View full report in Codecov by Sentry. |
FlipperPA
reviewed
Oct 14, 2024
| @@ -54,6 +54,7 @@ class MyExampleViewSet(XLSXFileMixin, ReadOnlyModelViewSet): | |||
| serializer_class = MyExampleSerializer | |||
| renderer_classes = (XLSXRenderer,) | |||
| filename = 'my_export.xlsx' | |||
| pagination_class = None # if you have custom pagination, you need to set this to None | |||
There was a problem hiding this comment.
Inline comments should be at least two spaces after the code: https://peps.python.org/pep-0008/#inline-comments
I'll take care of this. Thanks for your sleuthing!
FlipperPA
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for that issue
Fix #98