Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Django classifiers #97

Merged

Conversation

browniebroke
Copy link
Member

@browniebroke browniebroke commented Oct 12, 2024

Getting an error when trying to upload as it stands:

ERROR HTTPError: 400 Bad Request from https://upload.pypi.org/legacy/
'Framework :: Django :: 5' is not a valid classifier. See https://packaging.python.org/specifications/core-metadata for more information.

Looks like we need to specify the major and minor versions now: https://pypi.org/classifiers/

Getting an error when trying to upload as it stands:

ERROR HTTPError: 400 Bad Request from https://upload.pypi.org/legacy/

'Framework :: Django :: 5' is not a valid classifier.
See https://packaging.python.org/specifications/core-metadata for more information.
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@a14f81d). Learn more about missing BASE report.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #97   +/-   ##
=======================================
  Coverage        ?   92.87%           
=======================================
  Files           ?        4           
  Lines           ?      351           
  Branches        ?        0           
=======================================
  Hits            ?      326           
  Misses          ?       25           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@browniebroke browniebroke merged commit 48b09e5 into django-commons:main Oct 12, 2024
6 checks passed
@browniebroke browniebroke deleted the fix-django-classifiers branch October 12, 2024 16:38
@FlipperPA
Copy link
Member

We missed adding the trove classifier for Django 5, that exists for prior releases. I've issued a PR:
pypa/trove-classifiers@main...FlipperPA:trove-classifiers:patch-2

They're normally pretty fast!

@browniebroke
Copy link
Member Author

I thought that was done on purpose, Django doesn't strictly follows semver, and there might be some breaking changes in minor releases. A package running in version X.Y is not guaranteed to work with X.Y+1

@FlipperPA
Copy link
Member

Since before my time, Django has always had trove classifiers for major versions (you can see they exist for version 1, 2, 3, and 4). Breaking changes in minor releases are fairly rare in packages, and I think have the major release classifiers allows for a bit less churn in packages, just to update their classifiers. Maybe that has changed, but I didn't see any discussion - I guess we'll see if there's any comment on the PR. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants