Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Officially drop support for Python 3.7 and 3.8 #94

Merged
merged 3 commits into from
Oct 16, 2024

Conversation

browniebroke
Copy link
Member

@browniebroke browniebroke commented Oct 11, 2024

Python 3.7 has EOL for more than a year, it's is not listed in the trove classifiers and is not part of the test suite. Python 3.8 has reached EOL earlier this month:

image

https://devguide.python.org/versions/

@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@a14f81d). Learn more about missing BASE report.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #94   +/-   ##
=======================================
  Coverage        ?   92.87%           
=======================================
  Files           ?        4           
  Lines           ?      351           
  Branches        ?        0           
=======================================
  Hits            ?      326           
  Misses          ?       25           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@browniebroke
Copy link
Member Author

@FlipperPA does this make sense? I'm also planing to drop Python 3.8 which reached EOL this month, and look into adding Python 3.13 support.

Then perhaps we could do a 2.5.0 release? WDYT?

@FlipperPA
Copy link
Member

@browniebroke Absolutely, let's drop 3.8 as well, and a 2.5.0 release sounds great. Also, the new Trove Classifiers are merged in:
pypa/trove-classifiers#193

pyproject.toml Outdated Show resolved Hide resolved
@browniebroke browniebroke changed the title Officially drop support for Python 3.7 Officially drop support for Python 3.7 and 3.8 Oct 16, 2024
@browniebroke browniebroke merged commit 1af6040 into django-commons:main Oct 16, 2024
5 checks passed
@browniebroke browniebroke deleted the drop-python3.7 branch October 16, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants