Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support nullable ListFields with django-rest-framework #78

Merged
merged 4 commits into from
Oct 11, 2024

Conversation

Rmvandiepen
Copy link
Contributor

As mentioned in #61 it doesn't work when a ListField has a null value in it.
This should fix that 🥳

@FlipperPA
Copy link
Member

@Rmvandiepen Hey, I very much appreciate the PR! I'm hoping to take some time at DjangoCon US this week during sprints to catch up on merges. Didn't want you to think I was ignoring you!

@FlipperPA
Copy link
Member

@rptmat57 @melvinkcx This is a PR for NULL fields. I'm pretty sure we still need to merge this one to cover all edge cases, but wanted to run it by both of you since you encountered and fixed the edge case from yesterday. Thoughts?

Copy link
Contributor

@melvinkcx melvinkcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rptmat57
Copy link
Contributor

same, looks good!

# Conflicts:
#	drf_excel/fields.py
@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@339e088). Learn more about missing BASE report.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #78   +/-   ##
=======================================
  Coverage        ?   92.87%           
=======================================
  Files           ?        4           
  Lines           ?      351           
  Branches        ?        0           
=======================================
  Hits            ?      326           
  Misses          ?       25           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@browniebroke browniebroke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've merged in latest chanegs from the main branch and expended the new test suite to cover this extra case, which made me realised that the empty list case wasn't covered

@browniebroke browniebroke merged commit aa02c51 into django-commons:main Oct 11, 2024
6 checks passed
@browniebroke
Copy link
Member

Thanks a lot for your contribution and your patience 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants