-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support nullable ListFields with django-rest-framework #78
Conversation
@Rmvandiepen Hey, I very much appreciate the PR! I'm hoping to take some time at DjangoCon US this week during sprints to catch up on merges. Didn't want you to think I was ignoring you! |
@rptmat57 @melvinkcx This is a PR for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
same, looks good! |
# Conflicts: # drf_excel/fields.py
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #78 +/- ##
=======================================
Coverage ? 92.87%
=======================================
Files ? 4
Lines ? 351
Branches ? 0
=======================================
Hits ? 326
Misses ? 25
Partials ? 0 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've merged in latest chanegs from the main branch and expended the new test suite to cover this extra case, which made me realised that the empty list case wasn't covered
Thanks a lot for your contribution and your patience 🎉 |
As mentioned in #61 it doesn't work when a ListField has a null value in it.
This should fix that 🥳