Add Typing #13
Open
Add Typing #13
+781
−213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfouque
force-pushed
the
mypy_level_1
branch
6 times, most recently
from
c7fcdc0 to
0b001e6
Compare
adamchainz
reviewed
Nov 22, 2023
pfouque
commented
Nov 22, 2023
pfouque
force-pushed
the
mypy_level_1
branch
2 times, most recently
from
90c05e1 to
9194723
Compare
pfouque
force-pushed
the
main
branch
5 times, most recently
from
ca653bf to
4e3ac13
Compare
pfouque
force-pushed
the
mypy_level_1
branch
4 times, most recently
from
8e77aac to
4251f54
Compare
pfouque
force-pushed
the
mypy_level_1
branch
from
d8836db to
3f506d5
Compare
Contributor
|
Please rebase.
|
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
pfouque
force-pushed
the
mypy_level_1
branch
4 times, most recently
from
3fd9cab to
cebd6e9
Compare
pfouque
commented
Jan 21, 2026
| self.model.publish() | ||
| assert self.model.state == "published" | ||
| transitions = self.model.get_available_state_transitions() | ||
| transitions = self.model.get_available_state_transitions() # type: ignore[attr-defined] |
Member
Author
There was a problem hiding this comment.
would be nice to find a way to add typing dynamically...
pfouque
commented
Jan 21, 2026
| class DeferrableModel(models.Model): | ||
| state = FSMField(default="new") | ||
|
|
||
| objects: ClassVar[models.Manager[DeferrableModel]] = models.Manager() |
Member
Author
There was a problem hiding this comment.
I noticed models declared in tests doesn't benefit from django stubs magic ... :(
pfouque
force-pushed
the
mypy_level_1
branch
3 times, most recently
from
c5561fe to
532d6ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12