Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Modify language menu for pages only if it is present #179

Merged
merged 6 commits into from
May 26, 2023
Merged

fix: Modify language menu for pages only if it is present #179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
32b444b
fix: toolbar fails if language menu is not present
fsbraun May 25, 2023
c653f45
Merge branch 'master' into fix/language_menu
fsbraun May 25, 2023
a93d473
update test environment
fsbraun May 25, 2023
928cba3
Add test
fsbraun May 25, 2023
ea99111
Update compile.py
fsbraun May 26, 2023
d9a95bd
Update tests/test_toolbar.py
fsbraun May 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions djangocms_alias/cms_toolbars.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,8 @@ def enable_create_wizard_button(self):

def override_language_switcher(self):
language_menu = self.toolbar.get_menu(LANGUAGE_MENU_IDENTIFIER, _('Language'))
if not language_menu:
return
# Remove all existing language links
# remove_item uses `items` attribute so we have to copy object
for _item in copy(language_menu.items):
Expand Down
2 changes: 1 addition & 1 deletion tests/requirements/compile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ def run(*args, **kwargs):
"-m",
"piptools",
"compile",
"--generate-hashes",
# temporarily remove "--generate-hashes", until all dependencies are actual releases
"--allow-unsafe",
] + sys.argv[1:]

Expand Down
167 changes: 0 additions & 167 deletions tests/requirements/djmain-py310-default.txt
View file
Open in desktop

This file was deleted.

Loading