disable reregister phar

php_micro.c

@@ -658,10 +658,10 @@ int main(int argc, char *argv[])
         zend_interned_strings_switch_storage(0);
         // hook at here for some extensions that will register proto
         // TODO: zip
-        if (SUCCESS != (exit_status = micro_reregister_proto("phar"))) {
-            // if hook failed, go error
-            goto out;
-        }
+        // if (SUCCESS != (exit_status = micro_reregister_proto("phar"))) {
+        //     // if hook failed, go error
+        //     goto out;
+        // }
         // switch back
         zend_interned_strings_switch_storage(1);
 
@@ -739,7 +739,7 @@ int main(int argc, char *argv[])
     if (ini_entries) {
         free(ini_entries);
     }
-    micro_free_reregistered_protos();
+    // micro_free_reregistered_protos();
     if (module_started) {
         dbgprintf("mshutdown\n");
         php_module_shutdown();

tests/.gitignore

@@ -8,3 +8,5 @@
 */*.log
 */*.sh
 
+*/*.phar
+

tests/micro/phar.phpt

@@ -0,0 +1,219 @@
+--TEST--
+Test $argv variable things
+--SKIPIF--
+<?php
+if("micro" !== php_sapi_name()){
+    die("SKIP because this test is only for micro SAPI");
+}
+if(!extension_loaded("phar")){
+    die("SKIP because phar extension is required");
+}
+?>
+--INI--
+phar.readonly=0
+--FILE--
+<?php
+
+chdir(__DIR__);
+
+@unlink("testphar.phar");
+@unlink("testphar.phar.gz");
+
+$phar = new Phar("testphar.phar");
+
+$index = <<<'PHP'
+<?php
+
+echo "index.php\n";
+
+echo "include seek_self.inc from phar\n";
+include_once __DIR__ . "/seek_self.inc";
+
+echo "include seek_self.inc from dir\n";
+include_once getcwd() . "/seek_self.inc";
+
+echo "include lv1.php from phar\n";
+include_once __DIR__ . "/lv1.php";
+
+echo "list phar dir\n";
+$dir = opendir(__DIR__);
+$items = [];
+while($item = readdir($dir)){
+    $items[] = $item;
+}
+sort($items);
+var_dump($items);
+
+PHP;
+
+$lv1 = <<<'PHP'
+<?php
+
+echo "lv1.php\n";
+
+echo "include lv2.php from phar\n";
+include_once __DIR__ . "/lv2.php";
+
+PHP;
+
+$lv2 = <<<'PHP'
+<?php
+
+echo "lv2.php\n";
+
+echo "include lv3.php from phar\n";
+include_once __DIR__ . "/lv3.php";
+
+PHP;
+
+$lv3 = <<<'PHP'
+<?php
+
+echo "lv3.php\n";
+
+PHP;
+
+$phar->startBuffering();
+$phar->addFromString("index.php", $index);
+$phar->addFromString("lv1.php", $lv1);
+$phar->addFromString("lv2.php", $lv2);
+$phar->addFromString("lv3.php", $lv3);
+// NOTE: seek_self.inc have different behavior in phar
+// so the expect is different, this is not a bug.
+$phar->addFile("seek_self.inc", "seek_self.inc");
+$phar->stopBuffering();
+
+if ($phar->canCompress(Phar::GZ)) {
+    $phar->compress(Phar::GZ);
+}
+$phar->setDefaultStub("index.php", "index.php");
+
+$selffile = micro_open_self();
+$exe = fopen("phartest.exe", "wb");
+for ($i = 0; $i < micro_get_sfxsize(); $i += 8192) {
+    $read = fread($selffile, micro_get_sfxsize() - $i > 8192 ? 8192 : micro_get_sfxsize() - $i);
+    fwrite($exe, $read);
+}
+
+fwrite($exe, file_get_contents("testphar.phar"));
+fflush($exe);
+fclose($exe);
+fclose($selffile);
+
+chmod("phartest.exe", 0755);
+
+passthru("./phartest.exe", $ret);
+if ($ret !== 0) {
+    echo "Failed to execute phar\n";
+    exit(1);
+}
+
+echo "Done\n";
+?>
+--CLEAN--
+<?php
+
+chdir(__DIR__);
+
+@unlink("testphar.phar");
+@unlink("testphar.phar.gz");
+@unlink("phartest.exe");
+
+?>
+--EXPECTF--
+index.php
+include seek_self.inc from phar
+string(4) "<?ph"
+int(-1)
+bool(false)
+string(0) ""
+int(0)
+int(0)
+string(4) "<?ph"
+int(0)
+int(1)
+string(4) "?php"
+int(0)
+int(5)
+string(4) "
+
+$s"
+int(0)
+int(5)
+string(4) "
+
+$s"
+int(-1)
+bool(false)
+string(0) ""
+int(0)
+string(0) ""
+int(-1)
+string(0) ""
+bool(false)
+int(1585)
+Failed to seek to the end of the file
+int(-1)
+string(0) ""
+bool(false)
+int(1585)
+Failed to seek to the end of the file
+int(-1)
+string(0) ""
+bool(false)
+int(1585)
+Failed to seek to the end of the file
+Done
+include seek_self.inc from dir
+string(4) "<?ph"
+int(-1)
+int(4)
+string(0) ""
+int(0)
+int(0)
+string(4) "<?ph"
+int(0)
+int(1)
+string(4) "?php"
+int(0)
+int(5)
+string(4) "
+
+$s"
+int(0)
+int(5)
+string(4) "
+
+$s"
+int(0)
+int(1000008)
+string(0) ""
+int(0)
+string(0) ""
+int(0)
+string(0) ""
+int(-1)
+string(0) ""
+int(0)
+string(0) ""
+Done
+include lv1.php from phar
+lv1.php
+include lv2.php from phar
+lv2.php
+include lv3.php from phar
+lv3.php
+list phar dir
+array(5) {
+  [0]=>
+  string(9) "index.php"
+  [1]=>
+  string(7) "lv1.php"
+  [2]=>
+  string(7) "lv2.php"
+  [3]=>
+  string(7) "lv3.php"
+  [4]=>
+  string(13) "seek_self.inc"
+}
+Done

tests/micro/seek_self.inc

@@ -0,0 +1,75 @@
+<?php
+
+$self = fopen(__FILE__, 'r');
+
+var_dump(fread($self, 4));
+
+$ret = fseek($self, -4, SEEK_SET);
+var_dump($ret);
+var_dump(ftell($self));
+var_dump(fread($self, 4));
+
+$ret = fseek($self, 0, SEEK_SET);
+var_dump($ret);
+var_dump(ftell($self));
+var_dump(fread($self, 4));
+
+$ret = fseek($self, 1, SEEK_SET);
+var_dump($ret);
+var_dump(ftell($self));
+var_dump(fread($self, 4));
+
+$ret = fseek($self, 0, SEEK_CUR);
+var_dump($ret);
+var_dump(ftell($self));
+var_dump(fread($self, 4));
+
+$ret = fseek($self, -4-$ret, SEEK_CUR);
+var_dump($ret);
+var_dump(ftell($self));
+var_dump(fread($self, 4));
+
+$ret = fseek($self, 999999, SEEK_CUR);
+var_dump($ret);
+var_dump(ftell($self));
+var_dump(fread($self, 4));
+
+$ret = fseek($self, 0, SEEK_END);
+var_dump($ret);
+var_dump(fread($self, 4));
+
+$fileSize = ftell($self);
+
+$ret = fseek($self, 4, SEEK_END);
+var_dump($ret);
+var_dump(fread($self, 4));
+
+if ($fileSize + 4 != ftell($self)) {
+    var_dump(ftell($self), $fileSize);
+    echo "Failed to seek to the end of the file\n";
+}
+
+$ret = fseek($self, -99999, SEEK_END);
+var_dump($ret);
+var_dump(fread($self, 4));
+
+if ($fileSize + 4 != ftell($self)) {
+    var_dump(ftell($self), $fileSize);
+    echo "Failed to seek to the end of the file\n";
+}
+
+$ret = fseek($self, 0, SEEK_CUR);
+var_dump($ret);
+var_dump(fread($self, 4));
+
+if ($fileSize + 4 != ftell($self)) {
+    var_dump(ftell($self), $fileSize);
+    echo "Failed to seek to the end of the file\n";
+}
+
+if (fstat($self)['size'] != $fileSize) {
+    var_dump(fstat($self)['size'], $fileSize);
+    echo "Failed to seek to the end of the file\n";
+}
+
+echo "Done\n";

tests/micro/seek_self.phpt

@@ -5,6 +5,7 @@ Test fseek() fstat() with micro hooks
 if("micro" !== php_sapi_name()){
     die("SKIP because this test is only for micro SAPI");
 }
+?>
 --FILE--
 <?php