-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide stand-alone pbench server container for external integration #3081
Provide stand-alone pbench server container for external integration #3081
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found a few small things to attend to.
8ef5b98
to
e744ecc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a few concerns:
- I think it is premature to be removing support from the CI for using both internal and external container image registries.
- I'm not sure how the container will function without the Pip installs.
- I don't think that combining the various pod spec YAML files is actually producing a benefit -- I think the proliferation of parameters makes it unusable for humans without a wrapper script (which isn't included in this PR). (I think it would probably be better to just delete the previous
pod.yml
file, as I don't think we're going to require a pod with pre-loaded data.)
And, there are some other smaller items and questions.
FWIW, I've pulled a few of these commits off into PR #3087 since they are independent of the direction suggested by this PR. |
2e62d8f
to
498d267
Compare
This comment was marked as resolved.
This comment was marked as resolved.
782e20f
to
07eaf26
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe I have addressed all out-standing review comments. Thank you, everyone!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Remove use of unused `default-host` and anything that depended on it. This allows us to avoid fixing up the pbench server configuration file for the in-a-can server container. We also make a change to always copy the HTTPD pbench server conf file into place, but only fix it up with the right host name for the in-a-can environment.
If we have the module, mod_logio, enhance the HTTPD access logs to emit time-to-first-byte sent in microseconds, # of bytes received (including request and headers), and # of bytes sent.
We also move the document root for serving files to be: /srv/pbench/public_html This has a number of advantages. It gives us one external mount point for the production deployment, so that the dashboard is served from the same volume. It also means the `404.html` and `50x.html` pages that are referenced in the Nginx configuration can eventually provided by the dashboard. We can also take advantage of a `maintenance.json` "page", where the presence of that file will cause Nginx to server a 597 code, and its JSON payload will be pulled from that file. Finally, this allows us to provide a method for serving the old legacy pages for the Agent generated HTML.
Replace the commented out `buildah login` command line with a more informative description of how to login using an application token.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Provide a stand-alone pbench server container for external integration.
A number of the previous commits in this PR were pulled out into separate PRs, most notably PR2 #3108, #3112, #3130, #3131, #3132, and #3133.
Below are the individual itemized commits we are working with to finalize stand-alone Pbench Server container image:
default-host
ERR
or of a shell commandPB_POD_NAME
settingjenkins/runlocal
inline with CI pipelinemod_logio
formatting for TTFB, in, and out