[I85] Upgrade to Strapi 5 and add Jest + ESLint + Prettier #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corasaurus-hex
commented
Aug 5, 2024
| @@ -1,22 +1,27 @@ | |||
| export default ({ env }) => ({ | |||
| auth: { | |||
| secret: env('ADMIN_JWT_SECRET'), | |||
| secret: env("ADMIN_JWT_SECRET"), | |||
There was a problem hiding this comment.
Prettier makes you pick either single or double quotes, and I like double quotes, so here we are
corasaurus-hex
commented
Aug 5, 2024
| "check:format": "yarn format", | ||
| "check:build": "yarn build", | ||
| "check:test": "yarn test", | ||
| "check:all": "yarn check:types && yarn check:lint && yarn check:format && yarn check:build && yarn check:test", |
There was a problem hiding this comment.
This may feel like duplication but having a CI tasks in here (all the check: ones) as separate tasks from what you use directly frees us up to make further modifications to these tasks in the future.
This was referenced Aug 15, 2024
corasaurus-hex
force-pushed
the
feat/85/upgrade-to-strapi-5
branch
3 times, most recently
from
055dc17 to
379359e
Compare
- ESlint - Prettier - Jest - Bootstrap info Co-authored-by: Dierdre D Dixon <[email protected]>
corasaurus-hex
force-pushed
the
feat/85/upgrade-to-strapi-5
branch
from
379359e to
cb71c88
Compare
madcalf
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
#85
How can you test this?
yarnyarn check:all