fix payload of Edit Application Command Permissions and omitting of d…

…efault_permissions
disgoorg · Mar 18, 2022 · 1750445 · 1750445
1 parent aeea9da
commit 1750445
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/discord/application_command_create.go b/discord/application_command_create.go
@@ -13,7 +13,7 @@ type SlashCommandCreate struct {
 	CommandName       string                     `json:"name"`
 	Description       string                     `json:"description"`
 	Options           []ApplicationCommandOption `json:"options,omitempty"`
-	DefaultPermission bool                       `json:"default_permission,omitempty"`
+	DefaultPermission bool                       `json:"default_permission"`
 }
 
 func (c SlashCommandCreate) MarshalJSON() ([]byte, error) {
@@ -39,7 +39,7 @@ func (SlashCommandCreate) applicationCommandCreate() {}
 
 type UserCommandCreate struct {
 	CommandName       string `json:"name"`
-	DefaultPermission bool   `json:"default_permission,omitempty"`
+	DefaultPermission bool   `json:"default_permission"`
 }
 
 func (c UserCommandCreate) MarshalJSON() ([]byte, error) {
@@ -65,7 +65,7 @@ func (UserCommandCreate) applicationCommandCreate() {}
 
 type MessageCommandCreate struct {
 	CommandName       string `json:"name"`
-	DefaultPermission bool   `json:"default_permission,omitempty"`
+	DefaultPermission bool   `json:"default_permission"`
 }
 
 func (c MessageCommandCreate) MarshalJSON() ([]byte, error) {

diff --git a/discord/application_command_permission.go b/discord/application_command_permission.go
@@ -19,7 +19,7 @@ const (
 
 // ApplicationCommandPermissionsSet is used to bulk overwrite all ApplicationCommandPermissions
 type ApplicationCommandPermissionsSet struct {
-	ID          snowflake.Snowflake            `json:"id"`
+	ID          snowflake.Snowflake            `json:"id,omitempty"`
 	Permissions []ApplicationCommandPermission `json:"permissions"`
 }
 

diff --git a/rest/application_service.go b/rest/application_service.go
@@ -237,7 +237,7 @@ func (s *applicationServiceImpl) SetGuildCommandPermissions(applicationID snowfl
 	if err != nil {
 		return
 	}
-	err = s.restClient.Do(compiledRoute, commandPermissions, &commandPerms, opts...)
+	err = s.restClient.Do(compiledRoute, discord.ApplicationCommandPermissionsSet{Permissions: commandPermissions}, &commandPerms, opts...)
 	return
 }
-Original file line number
+Diff line change
@@ Expand Up @@
     	if err != nil {
     		return
     	}
-    	err = s.restClient.Do(compiledRoute, commandPermissions, &commandPerms, opts...)
+    	err = s.restClient.Do(compiledRoute, discord.ApplicationCommandPermissionsSet{Permissions: commandPermissions}, &commandPerms, opts...)
     	return
     }
@@ Expand Down @@