Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unreachable code in thumbhash_encoder_create (#129) #130

Closed
wants to merge 1 commit into from
+0 −3
Closed

Remove unreachable code in thumbhash_encoder_create (#129) #130

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions thumbhash.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,6 @@ struct thumbhash_encoder_struct {
thumbhash_encoder thumbhash_encoder_create(void* buf, size_t buf_len)
{
thumbhash_encoder e = new struct thumbhash_encoder_struct();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skidder wouldn't it be better to enclose this into a try-catch block? If the std::bad_alloc is encountered, we should catch it and return NULL since the function is already designed in a way that it returns NULL when new fails

if (!e) {
return NULL;
}
memset(e, 0, sizeof(struct thumbhash_encoder_struct));
e->dst = (uint8_t*)(buf);
e->dst_len = buf_len;
Expand Down