Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rich presence image examples with redesigned activity cards #7139

Merged
merged 9 commits into from
Sep 19, 2024

Conversation

bdbaraban
Copy link
Contributor

@bdbaraban bdbaraban commented Sep 13, 2024

Asana


We recently launched redesigned activity cards to 100% of users! This updates the documentation for the rich presence API to reflect changes, including:

  • New image examples
  • "Join Activity" >>> "Ask to Join"
  • Describing new state (party) behavior
I exported all assets from Figma at 3x resolution, and ran them through TinyPNG before uploading them here. Here are a bunch of screenshots! 📸 Screenshot 2024-09-12 at 5 35 38 PM Screenshot 2024-09-12 at 5 37 35 PM Screenshot 2024-09-12 at 5 37 54 PM Screenshot 2024-09-12 at 5 38 10 PM Screenshot 2024-09-12 at 5 46 05 PM Screenshot 2024-09-12 at 5 46 23 PM Screenshot 2024-09-12 at 5 46 48 PM Screenshot 2024-09-12 at 5 47 03 PM Screenshot 2024-09-12 at 5 47 20 PM Screenshot 2024-09-12 at 5 47 33 PM

@bdbaraban bdbaraban self-assigned this Sep 13, 2024
Copy link
Contributor

@valdotle valdotle Sep 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Join- and spectateSecret could maybe use the respective icons as well, to make the attribution clearer and the legend more consistent.
Furthermore, travelling (right half) has a typo...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll ask about updating the legend with badge icons!

Where is the typo in traveling?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently, that's my bad, something something British English...

Copy link
Contributor

@valdotle valdotle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will the rich presence visualizer be updated to reflect this as well?
And while the tables certainly might not be the best solution for these good-bad comparisons, I'm not sure if/how having the subtext in the image works with (dark/light) theming. You'd probably have to use a svg...

images/rp-good-art.png Outdated Show resolved Hide resolved
docs/rich_presence/Using_with_the_Game_SDK.mdx Outdated Show resolved Hide resolved
@bdbaraban
Copy link
Contributor Author

Will the rich presence visualizer be updated to reflect this as well? And while the tables certainly might not be the best solution for these good-bad comparisons, I'm not sure if/how having the subtext in the image works with (dark/light) theming. You'd probably have to use a svg...

Thanks for the catches! Yes, I had this PR in draft mode while we updated the assets to use gray backgrounds for legibility (just updated these now!). Following up with my team about your other catches.

What is the rich presence visualizer? Our team has not made plans to update this.

@valdotle
Copy link
Contributor

Thanks for the catches! Yes, I had this PR in draft mode while we updated the assets to use gray backgrounds for legibility (just updated these now!). Following up with my team about your other catches.

I guess a gray background works, though it's not the best solution at least the text should be visible now...

What is the rich presence visualizer? Our team has not made plans to update this.

This tool on the app page allowing for easy testing: image

@bdbaraban
Copy link
Contributor Author

I guess a gray background works, though it's not the best solution at least the text should be visible now...

Agreed. We updated to the gray background as an easy fix that matches how this problem is solved in current images.

This tool on the app page allowing for easy testing:

Thanks! Yeah ideally we should update this tool, too. Going to keep this out-of-scope of this PR, but will sync with my team about following up on this.

@bdbaraban bdbaraban marked this pull request as ready for review September 16, 2024 22:06
@bdbaraban bdbaraban requested a review from a team as a code owner September 16, 2024 22:06
@bdbaraban bdbaraban requested review from JustinBeckwith and removed request for a team, AlmostSuspense and valdotle September 16, 2024 22:06
@bdbaraban bdbaraban merged commit 081191f into main Sep 19, 2024
4 checks passed
@bdbaraban bdbaraban deleted the bdawg/rich-presence-images branch September 19, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants