-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update rich presence image examples with redesigned activity cards #7139
Conversation
Co-authored-by: Suspense <[email protected]>
images/rp-legend.png
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Join- and spectateSecret could maybe use the respective icons as well, to make the attribution clearer and the legend more consistent.
Furthermore, travelling (right half) has a typo...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll ask about updating the legend with badge icons!
Where is the typo in traveling
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently, that's my bad, something something British English...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will the rich presence visualizer be updated to reflect this as well?
And while the tables certainly might not be the best solution for these good-bad comparisons, I'm not sure if/how having the subtext in the image works with (dark/light) theming. You'd probably have to use a svg...
Thanks for the catches! Yes, I had this PR in draft mode while we updated the assets to use gray backgrounds for legibility (just updated these now!). Following up with my team about your other catches. What is the rich presence visualizer? Our team has not made plans to update this. |
I guess a gray background works, though it's not the best solution at least the text should be visible now...
|
Agreed. We updated to the gray background as an easy fix that matches how this problem is solved in current images.
Thanks! Yeah ideally we should update this tool, too. Going to keep this out-of-scope of this PR, but will sync with my team about following up on this. |
Asana
We recently launched redesigned activity cards to 100% of users! This updates the documentation for the rich presence API to reflect changes, including:
state (party)
behaviorI exported all assets from Figma at 3x resolution, and ran them through TinyPNG before uploading them here. Here are a bunch of screenshots! 📸