feat!: change export path #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moki
requested changes
Sep 21, 2023
.gitignore
Outdated
| @@ -2,4 +2,6 @@ node_modules/ | |||
| www/ | |||
| bundle/ | |||
|
|
|||
| .idea | |||
There was a problem hiding this comment.
this is your machine specific configuration and should not be in the repository
use global git config
https://stackoverflow.com/questions/7335420/global-git-ignore
|
lgtm one small thing tho, can you please clean up commit history? or three commits into one? |
moki
previously approved these changes
Sep 22, 2023
martyanovandrey
force-pushed
the
fixImport
branch
from
2c15f80 to
3a6b97b
Compare
moki
requested changes
Sep 24, 2023
|
|
||
| export type PlaygroundProperties = { | ||
| content?: string; | ||
| tabs?: { id: string, title: string }[]; |
There was a problem hiding this comment.
we are allowing to choose from predefined tabs(with transformations that goes with them)
each id has transformations tied up to them: md2html(preview), md2html(raw), md2md, etc...
change type to
tabs?: Tabs[]
export type Tabs = {
id: 'preview' | 'html' | 'markdown' | 'tokens';
title: string;
}
moki
reviewed
Sep 24, 2023
| @@ -38,7 +38,7 @@ | |||
| padding: var(--g-text-body-1-font-size); | |||
| } | |||
|
|
|||
| .area__card > section { | |||
| .area-card__editor > section { | |||
There was a problem hiding this comment.
since you are nuking borders from html preview, can you also remove borders from other tabs.
now layout "jumping" because of that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.