feat: decouple the FIX_INTERNAL_EDGES from the ORIENTED trimesh flags #333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, enabling the
TriMeshFlags::FIX_INTERNAL_EDGESflag on aTriMeshwould automatically enable theORIENTEDflag too. This is problematic because some users (on rapier in particular) want to enableFIX_INTERNAL_EDGESon open meshes. While this is technically valid, the impliedORIENTEDflag results in some incorrect collision-detection between mesh and balls due to the malformed interior of these open meshes.This PR decouples both flags so that
FIX_INTERNAL_EDGEScan be specified without having an impact on point projection.