[webpack] Reports and report-dependent code #35599
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The non-minified version of datatables errors out. This is the B3 library so I'm not going to worry about it. Webpack will minify it.
These should now be included directly in js files where they're needed.
orangejenny
added
Open for review: do not merge
orangejenny
requested review from
a team,
calellowitz,
biyeun and
kaapstorm
as code owners
dimagimon
added
dependencies
millerdev
approved these changes
Jan 9, 2025
|
looks like test failures are due to bootstrap diffs. thank you for doing this! looks great! |
|
@biyeun Totally forgot about diffs, thanks, I'll add those. |
|
There's also a real test failure, which is intriguing, I'll check that out. |
These tests aren't using bundling, which means they're dependent on the ordering of script tags.
|
@orangejenny had an issue loading submissions by form report. Looks like fixed columns is missing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technical Summary
This moves standard reports, UCR, admin reports, microplanning reports, other one-off reports (e.g., linked project space history and repeat records), custom reports, data interfaces, the export download page, and the view lookup table page to webpack. It's a mixture of areas that were already on requirejs and areas that were still using script tags.
I've been holding off on PRing this until some work extracting the inddex reports' inline js into a separate file was complete (#35586). I'm still working through some bugs in that work, which is why this PR is marked don't merge, but decided it's time to open this PR for review. QA is already complete.
Safety Assurance
Safety story
This is fairly risky from a UI perspective, with the risk being disabling one or more of these UIs. There's no deeper risk to data, etc. QA has done extensive testing.
Automated test coverage
Not much.
QA Plan
https://dimagi.atlassian.net/browse/QA-7353
Rollback instructions
This is a big PR that probably won't roll back cleanly for very long, but there's no technical reason not to roll it back.
Labels & Review