Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose IgResponse in the Request class $end subject #1303

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Expose IgResponse in the Request class $end subject #1303

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/core/request.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ interface SignedPost {

export class Request {
private static requestDebug = debug('ig:request');
end$ = new Subject();
end$ = new Subject<IgResponse<any>>();
error$ = new Subject<IgClientError>();
attemptOptions: Partial<AttemptOptions<any>> = {
maxAttempts: 1,
Expand Down Expand Up @@ -76,7 +76,7 @@ export class Request {
Request.requestDebug(`Requesting ${options.method} ${options.url || options.uri || '[could not find url]'}`);
const response = await this.faultTolerantRequest(options);
this.updateState(response);
process.nextTick(() => this.end$.next());
process.nextTick(() => this.end$.next(response));
if (response.body.status === 'ok' || (onlyCheckHttpStatus && response.statusCode === 200)) {
return response;
}
Expand Down