Skip to content

Conversation

MizukiTemma
Copy link
Member

Short description

This PR adds a check box to enable/disable "Term explanations (Begriffslexikon)"

Proposed changes

  • Add a new field term_explanations_enabled to the model Region
  • Show it as checkboxin the region form

Side effects

  • should be none
  • note the new check box does not bring any effect whithin the CMS yet. Once the feature is done on both the CMS and app, term_explanations_enabled decides whether the team explanations that are registered in the CMS are shown in the app.

Faithfulness to issue description and design

There are no intended deviations from the issue and design.

Resolved issues

Fixes: #3090


Pull Request Review Guidelines

@MizukiTemma MizukiTemma added the blocked Blocked by external dependency label Aug 11, 2025
@MizukiTemma
Copy link
Member Author

Blocked as the prio of Term Explanations was questioned. https://chat.tuerantuer.org/digitalfabrik/pl/a86x49aipjrbdrrdz89st9g48r

@MizukiTemma MizukiTemma removed the blocked Blocked by external dependency label Aug 13, 2025
@MizukiTemma
Copy link
Member Author

Blocked as the prio of Term Explanations was questioned. https://chat.tuerantuer.org/digitalfabrik/pl/a86x49aipjrbdrrdz89st9g48r

The feature itself was not cancelled. As this PR is already ready for review, I'll suggest to review/merge it.

@JoeyStk
Copy link
Contributor

JoeyStk commented Aug 19, 2025

What should we do with this PR? Close it, but keep the branch and reopen it when it becomes relevant again? 🤔

@MizukiTemma
Copy link
Member Author

What should we do with this PR? Close it, but keep the branch and reopen it when it becomes relevant again? 🤔

@JoeyStk
I'm for merging it now, as it is only visible for staff users, does not require any further complicated inputs and you can even ignore while creating/editing a region. If we come back later, it's likely we suffer from rebasing chaos.

@JoeyStk
Copy link
Contributor

JoeyStk commented Aug 19, 2025

Hm... I'm a bit worried that this creates the expectation that we're working on the feature at the moment and that it'll be available soon. In the end I think this is a call for @hauf-toni :) What do you think? :)

@hauf-toni
Copy link

I'm with you @JoeyStk – unless there is an urgent need to release this for technical reasons we should wait for now and not release it yet.

@MizukiTemma MizukiTemma marked this pull request as draft August 19, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add setting in region settings to enable term explanations
3 participants