Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify API still works #2

Open
digilou opened this issue Oct 6, 2018 · 6 comments
Open

Verify API still works #2

digilou opened this issue Oct 6, 2018 · 6 comments
Labels
help wanted Extra attention is needed

Comments

@digilou
Copy link
Owner

digilou commented Oct 6, 2018

This API has been displaced. I need to verify that this still pulls in rover information, as is, despite being displaced. My Python and Django knowledge is lacking, so I need some help from an experienced Python and Django dev.

What needs to happen:

  • Run on your local machine.
  • Verify that the rover information is being pulled in.
  • If so, update README to share with others how to run this (with Python and Django) on a local machine for open use.
  • If unsuccessful, leave comments below and your results, and we can figure out a PR you can submit to get your Hactoberfest contribution to count.

Thanks for your help! 🙇‍♀️

@digilou digilou added hacktoberfest help wanted Extra attention is needed labels Oct 6, 2018
@djphan
Copy link

djphan commented Oct 6, 2018

I'll give this a shot and see what I can do

@djphan
Copy link

djphan commented Oct 6, 2018

Hm traditionally with Django projects we should be able to run the manage.py file with python manage.py runserver and looks like there are some errors with the project just starting up

The Output is: ImportError: Could not import settings 'mars_weather.settings' (Is it on sys.path? Is there an import error in the settings file?): No module named 'dj_database_url' right now. Looking into this

@djphan
Copy link

djphan commented Oct 6, 2018

Ah first roadblock cleared as I need to run pip install the dependancies - my django is rusty hehe.

The command is pip install -r requirements.txt in the directory of the project

@djphan
Copy link

djphan commented Oct 6, 2018

Ah new road block it looks like this error occurs in the pip install.

Failed building wheel for readline Running setup.py clean for readline Failed to build readline Installing collected packages: readline, requests, xmltodict Running setup.py install for readline ... error Complete output from command /usr/local/opt/python@2/bin/python2.7 -u -c "import setuptools, tokenize;__file__='/private/var/folders/57/ntj99lv143d9lqs7xlk3241c0000gn/T/pip-install-Uri33k/readline/setup.py';f=getattr(tokenize, 'open', open)(__file__);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, __file__, 'exec'))" install --record /private/var/folders/57/ntj99lv143d9lqs7xlk3241c0000gn/T/pip-record-fV3TCU/install-record.txt --single-version-externally-managed --compile:

@djphan
Copy link

djphan commented Oct 6, 2018

I wonder if this is an issue with the python version - as the project is very old and probably needs an update to the latest Django / be rewritten in python 3

@digilou
Copy link
Owner Author

digilou commented Oct 7, 2018

@djphan Thanks so much for the work you've put in so far! That is a good question, indeed. Though I'm not well-versed in Python, I am more familiar with v3 than v2. However, I would not be able to rewrite it myself. If I created a new issue for that, it would seem like a big task! Any more thoughts or suggestions?

If anything, larger actions are needed. I'm open to new issues submitted to this repo. You could update the README with an "Under Construction", so you can receive some credit for your detective work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants